Skip to content

chore(helm): hide atlassian + sentry in prod until their staging walks pass - #2530

Merged
lilyshen0722 merged 1 commit into
mainfrom
hold/hide-unwalked-connectors
Oct 23, 2026
Merged

chore(helm): hide atlassian + sentry in prod until their staging walks pass#2530
lilyshen0722 merged 1 commit into
mainfrom
hold/hide-unwalked-connectors

Conversation

@lilyshen0722

@lilyshen0722 lilyshen0722 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Conditional, so it stays a draft. Cofounder's plan B for tonight's prod deploy (~17:50 PT) is that anything not walked end to end on staging ships hidden. If CTO reports both Atlassian and Sentry walked before dispatch, this PR closes unmerged. If not, it goes in before the deploy. If only one passes, its line comes out first.

Change: values-dev.yaml hostedMcp.hiddenEntries adds atlassian and sentry next to google-calendar, using the #2401 switch. Rendered HOSTED_MCP_HIDDEN_ENTRIES = ["google-calendar","atlassian","sentry"]. Existing connections stay listed for removal, and grants/revocation keep using the pinned entry.

Verify after deploy: the live /v2/connectors page doesn't offer Atlassian or Sentry.

🤖 Generated with Claude Code

https://claude.ai/code/session_01V7T2fgquLRaqaYiGLC6Dey

@lilyshen0722 @claude
chore(helm): hide atlassian + sentry connectors in prod until their s…
6271a18 
…taging walks pass

Cofounder plan B (10-23): anything not walked end to end on staging ships
hidden. Uses the #2401 hostedMcp.hiddenEntries switch; existing connections
stay listed for removal. Remove each line once its walk passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V7T2fgquLRaqaYiGLC6Dey
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 9e32f25 and 6271a18.

📒 Files selected for processing: 1
  • k8s/helm/commonly/values-dev.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

The development Helm values now hide the Atlassian and Sentry hosted MCP entries. Comments state that they remain hidden until their staging walks pass.

Changes: Hosted MCP Visibility

Layer / File(s) Summary
Configure hidden hosted MCP entries
k8s/helm/commonly/values-dev.yaml		 The development values add atlassian and sentry to hostedMcp.hiddenEntries. Comments state that each integration remains hidden until its staging walk passes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related issues

Possibly related PRs

Merge Risk: ⚪ Minimal · up to 6271a

The development configuration adds the intended hidden hosted MCP entries and is ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the Helm change and the condition for hiding Atlassian and Sentry in production.
Description check Passed The description directly explains the conditional deployment plan, the hidden entries, the rendered configuration, and the verification step.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lilyshen0722
lilyshen0722 marked this pull request as ready for review October 23, 2026 18:43
@lilyshen0722

lilyshen0722 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Gate asked: @sable at exact head 6271a18336fcd4d50dbaf33e5832957cd1254292. Presses after 16:30 for the evening deploy.

@coderabbitai coderabbitai Bot mentioned this pull request Oct 23, 2026
Merged
@lilyshen0722 lilyshen0722 mentioned this pull request Oct 23, 2026
Merged
@lilyshen0722

lilyshen0722 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Gate asked: @vera at exact head 6271a18336fcd4d50dbaf33e5832957cd1254292, verdict by 16:15 PT.

lilyshen0722
lilyshen0722 commented Oct 23, 2026
View reviewed changes

@lilyshen0722 lilyshen0722 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE GATE: PASS @ 6271a18

Verdict

Approve for the stated configuration property. The diff against current main changes only k8s/helm/commonly/values-dev.yaml: it appends atlassian and sentry to the existing google-calendar hidden list. No other value changes, and git diff --check is clean.

Evidence

Rendering the exact PR chart with main's values-dev and then the head's values-dev changes only HOSTED_MCP_HIDDEN_ENTRIES in the backend and ops-runner deployments, from ["google-calendar"] to ["google-calendar","atlassian","sentry"]. Current release values also report ["google-calendar"]. The deploy workflow applies values-dev; the backend's catalogue filters IDs in that list, while existing hidden connections remain available for removal and the connect start route refuses a hidden entry. GitHub checks are green, including Chart Lint. git merge-tree with current main is clean.

The release uses a private values overlay after values-dev, which is unavailable in this checkout. This gate covers the committed configuration and chart render; confirm the live environment value and Connectors page after deployment. The PR's conditional press decision remains with the release owner.

Written by Vera, a Commonly agent (https://commonly.me/pods/6a8f6dc7a1dccf2e02f31015)
GATE: PASS

@coderabbitai coderabbitai Bot mentioned this pull request Oct 23, 2026
Merged
@lilyshen0722
lilyshen0722 added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit 7284d6a Oct 23, 2026
30 checks passed
samxu01 pushed a commit that referenced this pull request Oct 23, 2026
@lilyshen0722 @claude
chore(helm): hide notion, gitlab and supabase until each is walked (s…
a4e08d7 
…hips with #2429)

#2429 adds the Notion, GitLab.com and Supabase hosted entries (ids from its
entries.ts: notion, gitlab, supabase). Cofounder ruled they ship hidden until
walked end to end, like Atlassian and Sentry (#2530).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V7T2fgquLRaqaYiGLC6Dey
samxu01 pushed a commit that referenced this pull request Oct 24, 2026
@lilyshen0722 @claude wren
docs(plans): fill TASK-270's rows from the 10-23 staging walk
a235d7c 
Both entries are deployed and hidden on commonly.me since #2530. The
rows now carry #2536's staging results: Sentry green on staging in C0,
C1 and C2; Atlassian C1 blocked by the site's MCP-server-domain
allowlist. The fill-in section becomes the walk's checks, with the cells
staging could not reach (any agent tool call) left for the walk on
commonly.me. The Hosted MCP row no longer lists the reconnect
withdrawal as open: #2072 built it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: wren <WyJ3cmVuIiwiZGVmYXVsdCJd@agents.commonly.invalid>
Agent-Model: claude/claude-opus-5-5/max
@lilyshen0722 lilyshen0722 mentioned this pull request Oct 24, 2026
Merged
This was referenced Oct 24, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lilyshen0722