Repository navigation
test: raise the security package line budget to its size on main - #31469
Conversation
The budget raise in #30600 was measured on a base without the security fixes that merged before it, so main landed 34 lines over budget and test_the_package_stays_within_its_line_budget fails on every PR. Set the budget to the measured size. No code change.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this PR changes one test constant to match the measured package size and touches no runtime code or surface. Notes
[DESIGN-REVIEWED] 1446a3d Description read[DESCRIPTION-READ] 1a7da68b9217de23645a0ded0d5e83793ea842df3f3e156fb237cd58f465e331 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Approving 1446a3d.
What I checked on this head:
- The diff is only the line budget fix in
test/test_security_gate_liveness.py:_PACKAGE_LINE_BUDGETgoes from 34,699 to 34,733, plus a comment that says why. No product code changes. - It loosens a test ceiling and does not tighten anything. The per-file ceiling next to it is untouched.
- Checks: 0 red.
Source GatesandAwait Fast Gatepassed, and no non-shard check is red or pending. The Design and GPT lanes passed, the Opus lane found nothing, and the UX and First Principles lanes were skipped for a change with no user-facing surface. - Only the numbered backend test shards and PR Readiness are still running. The budget test runs in those shards, so the measured size on this head is confirmed there.
I did not set auto-merge, because it is already set on this PR.
Problem / Motivation
Goal: Main's backend test shards pass again: the security package line budget matches the package's real size.
test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budgetfails on main since #30600 (package grew to 34733 lines, budget 34,699). #30600 raised the budget by 175, measured on a base without the security fixes that merged before it, so main landed 34 lines over. Every PR's Backend Tests shard 2 (Linux and Windows) is red from it.Why it matters
Every open PR shows a red backend shard it did not cause, and readiness stays red for all of them.
Not a goal
What changed (motivation → approach → change)
_PACKAGE_LINE_BUDGETgoes from 34,699 to 34,733, the size measured on main at85ce466709, with a note on why. Test-only.Backwards compatibility
Compatible: test-only; no runtime code changes.
Removes nothing: the budget only grows to the measured size.
Tests
test/test_security_gate_liveness.py: 10 passed locally (one process, no xdist); the budget test fails on main without this change.Proof: not provable -- test-only change
Manual verification
N/A — unit coverage sufficient: the change is one constant in a test.
Related Issues
Follow-up to #30600.
Sibling sweep
Swept: git grep -n "_LINE_BUDGET = " -- test/test_security_gate_liveness.py
Siblings: none -- the package budget is the only total-size budget in that test
Pattern harvest
Not generalizable: two budget raises measured on different bases; the merge queue would catch the race.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)