Skip to content

test: raise the security package line budget to its size on main - #31469

Merged
buluoray merged 1 commit into
mainfrom
crew/slack/fix-security-line-budget
Nov 6, 2026
Merged

buluoray merged 1 commit into
mainfrom
crew/slack/fix-security-line-budget

Conversation

@buluoray

@buluoray buluoray commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Main's backend test shards pass again: the security package line budget matches the package's real size.

test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget fails on main since #30600 (package grew to 34733 lines, budget 34,699). #30600 raised the budget by 175, measured on a base without the security fixes that merged before it, so main landed 34 lines over. Every PR's Backend Tests shard 2 (Linux and Windows) is red from it.

Why it matters

Every open PR shows a red backend shard it did not cause, and readiness stays red for all of them.

Not a goal

  • Shrinking the security package.
  • Changing any security code or check.

What changed (motivation → approach → change)

_PACKAGE_LINE_BUDGET goes from 34,699 to 34,733, the size measured on main at 85ce466709, with a note on why. Test-only.

Backwards compatibility

Compatible: test-only; no runtime code changes.

Removes nothing: the budget only grows to the measured size.

Tests

  • test/test_security_gate_liveness.py: 10 passed locally (one process, no xdist); the budget test fails on main without this change.

Proof: not provable -- test-only change

Manual verification

N/A — unit coverage sufficient: the change is one constant in a test.

Related Issues

Follow-up to #30600.

Sibling sweep

Swept: git grep -n "_LINE_BUDGET = " -- test/test_security_gate_liveness.py
Siblings: none -- the package budget is the only total-size budget in that test

Pattern harvest

Not generalizable: two budget raises measured on different bases; the merge queue would catch the race.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

The budget raise in #30600 was measured on a base without the security fixes that merged before it, so main landed 34 lines over budget and test_the_package_stays_within_its_line_budget fails on every PR. Set the budget to the measured size. No code change.
@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 6, 2026 14:49
@buluoray
buluoray requested a review from Zedmor November 6, 2026 14:49
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 1446a3d7860354c3bf23ac8a83bbe9745ee192ac touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 1446a3d7860354c3bf23ac8a83bbe9745ee192ac ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@buluoray
buluoray enabled auto-merge (squash) November 6, 2026 14:50
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1446a3d7860354c3bf23ac8a83bbe9745ee192ac — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this PR changes one test constant to match the measured package size and touches no runtime code or surface.

Notes

  • The same race will happen again. Two PRs that each raise the budget, measured on different bases, can still land main over the limit. Measuring against the merge result would stop that, but it belongs in a separate PR.

[DESIGN-REVIEWED] 1446a3d

Description read

[DESCRIPTION-READ] 1a7da68b9217de23645a0ded0d5e83793ea842df3f3e156fb237cd58f465e331

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1446a3d7860354c3bf23ac8a83bbe9745ee192ac — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1446a3d

Verdict parsed from the review's SHA-scoped output markers for commit 1446a3d7860354c3bf23ac8a83bbe9745ee192ac.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1446a3d7860354c3bf23ac8a83bbe9745ee192ac false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1446a3d7860354c3bf23ac8a83bbe9745ee192ac and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1446a3d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1446a3d7860354c3bf23ac8a83bbe9745ee192ac false-positive: <reason, 20 to 500 characters>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 1446a3d.

What I checked on this head:

  • The diff is only the line budget fix in test/test_security_gate_liveness.py: _PACKAGE_LINE_BUDGET goes from 34,699 to 34,733, plus a comment that says why. No product code changes.
  • It loosens a test ceiling and does not tighten anything. The per-file ceiling next to it is untouched.
  • Checks: 0 red. Source Gates and Await Fast Gate passed, and no non-shard check is red or pending. The Design and GPT lanes passed, the Opus lane found nothing, and the UX and First Principles lanes were skipped for a change with no user-facing surface.
  • Only the numbered backend test shards and PR Readiness are still running. The budget test runs in those shards, so the measured size on this head is confirmed there.

I did not set auto-merge, because it is already set on this PR.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 6, 2026
@buluoray
buluoray merged commit 484ef40 into main Nov 6, 2026
96 checks passed
@buluoray
buluoray deleted the crew/slack/fix-security-line-budget branch November 6, 2026 15:48
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants