Skip to content

test: raise the security package line budget for the git publish check - #31625

Merged
buluoray merged 1 commit into
mainfrom
crew/slack/fix-security-line-budget-2
Nov 6, 2026
Merged

buluoray merged 1 commit into
mainfrom
crew/slack/fix-security-line-budget-2

Conversation

@buluoray

@buluoray buluoray commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Main's backend test shards pass again: the security package line budget covers the git publish check that merged in #30774.

test/test_security_gate_liveness.py::test_the_package_stays_within_its_line_budget fails on main since #30774 (package grew to 34753 lines, budget 34,733). #30774 added a net 20 lines to security/argv_floor_git.py without raising the budget, so every PR's Backend Tests shard is red from it.

Why it matters

Every open PR shows a red backend shard it did not cause, and readiness stays red for all of them.

Not a goal

  • Shrinking the security package.
  • Changing any security code or check.

What changed (motivation → approach → change)

_PACKAGE_LINE_BUDGET goes from 34,733 to 34,753, with a note in the test's existing style naming what #30774 added. Test-only.

Backwards compatibility

Compatible: test-only; no runtime code changes.

Removes nothing: the budget only grows by the 20 lines #30774 added.

Tests

  • test/test_security_gate_liveness.py: 10 passed on fresh origin/main 8095bc3e70 plus this change (one process, no xdist); the budget test fails there without it.

Proof: not provable -- test-only change

Manual verification

N/A — unit coverage sufficient: the change is one constant in a test.

Related Issues

Follow-up to #30774 and #31469.

Sibling sweep

Swept: git grep -n "_LINE_BUDGET = " -- test/test_security_gate_liveness.py
Siblings: none -- the package budget is the only total-size budget in that test

Pattern harvest

Not generalizable: a security change merged without its budget raise; the same budget raced once before (#31469).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

#30774 added 20 lines to argv_floor_git without raising the package budget, so main is 34,753 lines against 34,733 and test_the_package_stays_within_its_line_budget fails on every PR. Raise the budget by those 20. No code change.
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 589b119a9cfd5a5b12563d6c8410709f32aed2c3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a one-constant test-budget raise that matches the 20 lines #30774 added. It changes no runtime code, takes nothing away, and adds no new user-facing surface.

Notes

[DESIGN-REVIEWED] 589b119

Description read

[DESCRIPTION-READ] 40a0ec6a4714668ec278699dccc472536b05e29c3a49848aa01b3e4d161fc525

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 589b119a9cfd5a5b12563d6c8410709f32aed2c3 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 589b119a9cfd5a5b12563d6c8410709f32aed2c3 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 589b119a9cfd5a5b12563d6c8410709f32aed2c3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 589b119

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 589b119a9cfd5a5b12563d6c8410709f32aed2c3 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 589b119a9cfd5a5b12563d6c8410709f32aed2c3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 589b119

Verdict parsed from the review's SHA-scoped output markers for commit 589b119a9cfd5a5b12563d6c8410709f32aed2c3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 589b119a9cfd5a5b12563d6c8410709f32aed2c3 false-positive: <reason, 20 to 500 characters>

@chenmingwei23

Copy link
Copy Markdown
Contributor

VERDICT: APPROVE (MKT-APP head, at 589b119)

Reasons, read at this head:

  • The diff is test-only: one constant in test/test_security_gate_liveness.py, _PACKAGE_LINE_BUDGET 34_733 -> 34_753, plus a comment in the file's existing style. No src change, so no security behaviour moves.
  • The new value matches the measured size. On origin/main c0e9c2e the test fails with "package grew to 34753 lines", and it passes on 6e964a7, before fix: tighten a git publish check #30774.
  • The cause is right: 4b5126a (fix: tighten a git publish check #30774) is the only commit in 6e964a7..c0e9c2e that touches src/kiro_crew/security/ (+22 -2, argv_floor_git.py).
  • The per-file ceiling below is untouched, so the bound that matters is not relaxed.
  • Checks at this head: 70 pass, 0 fail, 6 pending.

This unblocks every PR whose Backend shard 2 and Coverage Gate fail on this test, #31601 included. It still needs a human maintainer's approval.

tim-finnigan pushed a commit that referenced this pull request Nov 6, 2026
The backend shards failed on test_the_package_stays_within_its_line_budget, a security-package budget that main raised in #31625 after this branch's merge ref was built. A re-run reuses the old merge ref, so this empty commit gives CI a fresh one. No content change.
tim-finnigan pushed a commit that referenced this pull request Nov 6, 2026
Two main-side reds reached this branch's merge refs: the security-package line budget (fixed on main by #31625) and the pull_request_target allowlist missing sensitive-change-review.yml (fixed by #31803). Neither touches files in this PR. Re-runs reuse the old merge ref, so this empty commit gives CI a fresh one. No content change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants