Repository navigation
feat(qmux): take a session config on every transport builder - #426
Conversation
The tcp, uds, tls and ws builders built their session from
`Config::negotiated`, so a caller could not raise the stream limits (or
any other flow-control setting) without dropping to `transport::Stream`
by hand. An application that holds a stream per subscription stalls
silently on MAX_STREAMS once it passes the default of 100.
Add `session_config` to `tcp::Config` and `uds::Config`, and
`with_session_config` to `tls::{Client, Server}` and
`ws::{Client, Server, Upgraded}`. The builder or the handshake still
decides the wire-format version and application protocol. Defaults are
unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughTransport entry points now accept session configuration while retaining their negotiated wire-format version and application protocol. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f22a621601
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The WebSocket builders start the session without awaiting transport parameters, so handshake_timeout has no effect there, and a record larger than the WebSocket frame limit is refused before QMux sees it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge summaryEvery qmux transport builder (tcp, uds, tls, ws) now takes a full Review: CI is green and CodeRabbit raised nothing. Codex left two P2 findings on
Suggested follow-ups (not created here):
Enabling squash auto-merge on 1cdb31a. (Written by Claude Opus 5.5) |
* quest: plan the WebSocket follow-ups from #426 Bound a silent WebSocket peer with handshake_timeout (a0) and advertise only a record size the WebSocket accepts (a1). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * quest: reject WebSocket limits below the record minimum Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Problem
The tcp, uds, tls and ws builders build their session from
Config::negotiated, so a caller cannot change the stream limits or any other flow-control setting without drivingtransport::Streamby hand, which loses the builders' TLS, ALPN and keep-alive handling. An application that holds a stream per subscription, as MoQ does, stalls silently on MAX_STREAMS once it passes the default of 100.Approach
Every builder takes a full
qmux::Config:session_configontcp::Configanduds::Config, matching their unprefixed setters, andwith_session_configontls::{Client, Server}andws::{Client, Server, Upgraded}, matching theirs. The builder or the handshake still decides the wire-format version and application protocol; every other setting comes from the config. The default stays at 100 streams.Impact
initial_max_streams_*.@moq/qmuxalready acceptsconfiginnew Session()andSession.accept(), so nothing changes there.Validation
configured_limit_holds_a_thousand_streamsholds 1,000 bidi and 1,000 uni streams throughws::Upgraded::with_session_configon paused time. With the config ignored, it stops at exactly 100.default_limit_stalls_at_a_hundred_streamspins the unchanged default.session_config_keeps_version_and_protocolscovers the tcp builder's merge.just checkandjust testpass.Follow-ups
Backport to
qmux-v0.5.xin a separate PR; it ships in 0.5.3 with #413.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.