Repository navigation
test(gui-user): fix nine catalog entries that name UI absent from main - #19683
Conversation
Nine records in features.json (table A of #19582) sent the GUI user-test lane to routes, controls or titles that are not on main. Each now names what the dashboard draws, and FEATURES.md is regenerated from the JSON. - chat-mcp-tools-panel: the panel is in the session options menu, there is no chat footer button - sidebar-crew-members-create-menu-entry: the entry is labelled Crewmates - chat-knowledge-picker-attach: the picker opens from an @kb, @knowledge or /kb search typed in the composer - chat-rewind: reached through Edit & Resend on a user message - developer-mcp-pool: the tab is MCP Management (tab key mcp-pool) - kas-auth-sign-in-card-signed-out: the card is on Settings > Agent Harness - standalone-logs: /logs renders inside the shell, with its chrome - sidebar-folders-history-and-archive: the pane is Older Sessions and the closed session has its real title - sidebar-workspace-switcher-three-workspaces: no switcher exists on main, so the record is excluded settings-overview and memory-browser repeated the sign-in card claim and get the same correction. The Rewind row of docs/feature-map/README.md named the same missing message action. Refs #19582
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 14730ef Description read[DESCRIPTION-READ] 6fb64935610a79db55ed1ba8efb05287cee6887564c9ac38442afabe166ea812 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
CI on this PR has been queued for six hours across three attempts. The same-repo routing sends my runs to the fleet (labels The Maintainers: could the fleet webhook admit my actor, or drop me from |
iamwhatever
left a comment
There was a problem hiding this comment.
This PR corrects the nine table-A records of #19582 in the GUI user-test catalog (features.json, the rendered FEATURES.md and one feature-map row) so the lane is no longer sent to routes and controls that are not on main; that is the root cause of those red entries, since the records were stale, not the product. I checked the claims against current main: McpInfoButton is only re-exported from pages/chat/index.ts and mounted nowhere, KiroSignInCard lives under pages/developer (no pages/settings copy exists), the menu label is "Crewmates" in en.manual.json, AssistantMessage.tsx has no rewind action, /logs is a plain Route in App.tsx, and no workspace switcher component exists in website/src. Moving the workspace-switcher record to excluded/P3 follows the catalog's own convention, and the counts in both the JSON and the Markdown tables move consistently (nightly 167->166, excluded 22->23, P2 162->161, P3 61->62). The change is data and docs only, so nothing at runtime changes. The red Backend/Frontend/Lint/Build entries are the cancelled fleet run 38350163424; the hosted re-run 38390769127 on the same head is green across every shard, and all five AI lanes pass or skipped with no findings. — crew-pr-reviewer (deep re-check)
Problem / Motivation
Goal: Make the GUI user-test catalog describe the dashboard that is on main, so a lane that follows the nine table-A entries of #19582 is not sent to routes, controls or titles that do not exist.
An agentic run over the catalog (#18614) left 86 entries red. #19582 triaged 35 of them as catalog or seed errors, and nine of those (its table A) name UI that is not on main or that lives elsewhere, so the lane can only fail them. Each of the nine was re-checked against
origin/mainat de2d143 withgit grep; the receipts are under What changed.Why it matters
The catalog is the backlog the GUI user-test lane works from. A record that sends the lane to a control the dashboard does not draw can only fail, and the failure reads as a product bug next to the real ones in the nightly report.
Not a goal
McpInfoButtoncomponent. The issue offers that as an alternative; this PR only stops the catalog from pointing at it.membersregistry title.What changed (motivation → approach → change)
Motivation: several surfaces moved after the records were written, and nothing re-reads a record against the code. Approach: for each record,
git grepthe route or control it names onorigin/main. Where it lives under another route or name, correctentry_path,title, notes andsource(ids andmerged_fromstay). Where nothing exists, mark the recordexcludedwith a reason, the catalog's own convention for flows the lane cannot drive (excludedis P3, so the record moves to the Not generated table). One line per record:chat-mcp-tools-panel:McpInfoButtonis mounted nowhere, it is only re-exported atwebsite/src/pages/chat/index.ts:5.McpToolsPanelrenders atwebsite/src/pages/chat/ChatPageMessageContent.tsx:155, inside the MCP servers submenu of the chat header's session options menu. The path and notes say so.sidebar-crew-members-create-menu-entry: the entry exists but reads "Crewmates" (open_crew_membersatwebsite/src/i18n/locales/en.manual.json:5667). The menu item isdata-testid="open-crew-members"atwebsite/src/pages/ChatSidebar.tsx:4729andopenCrewMembersatwebsite/src/pages/chat-sidebar/create.ts:191picks/membersor the Feature Previews card.chat-knowledge-picker-attach: there is no picker button.KnowledgePickermounts atwebsite/src/pages/ChatPage.tsx:6409only while a prefix search runs, started by the composer intercept (extractKnowledgeQueryatwebsite/src/pages/ChatPage.tsx:2081) for@knowledge,@kband/kb(PREFIXESatwebsite/src/pages/chat/useKnowledgeFetch.ts:27). The notes add that the memory-populated seed holds memory files and no knowledge source, so the lane must add one first.chat-rewind:git grep -i rewind origin/main -- website/src/pages/chat/AssistantMessage.tsxis empty. Rewind ishandleEditResendatwebsite/src/pages/ChatPage.tsx:3347, reached from Edit & Resend on a user message (aDropdownMenuItematwebsite/src/pages/chat/UserMessage.tsx:697, or thestartEditpencil button atwebsite/src/pages/chat/UserMessage.tsx:730) and served byapi_chat_slot_rewindatsrc/kiro_crew/dashboard/routes/sessions.py:76. The Rewind row ofdocs/feature-map/README.mdnamed the same missing message action and is corrected too.developer-mcp-pool: the route is right, the tab is MCP Management. Themcp-poolkey atwebsite/src/pages/DeveloperPage.tsx:45rendersMcpManagementwith a Servers table (stub switches) and a Sharing assessment view; it has no pool-state or probe control. Title, story, path and rationale are rewritten around those.kas-auth-sign-in-card-signed-out:website/src/pages/settings/KiroSignInCard.tsxdoes not exist. The card iswebsite/src/pages/developer/KiroSignInCard.tsx, mounted only in the KAS row of Agent Harness (KiroSignInCardatwebsite/src/pages/developer/AgentBackendTab.tsx:1550), linked asKIRO_SIGN_IN_PATHatwebsite/src/pages/developer/kiroSignInLink.ts:25;docs/system-specs/modules/kas-auth.mdsays it is deliberately not on Overview.start_urlbecomes/settings/agent(the validator rejects a query there).settings-overviewandmemory-browserrepeated the Overview claim and get the same correction; Overview mounts only the pointer atwebsite/src/pages/OverviewPage.tsx:334.memory-browserandsettings-overview; their text is corrected to match, nothing else about them changes.standalone-logs:/logsis aRoutein the shell's route list atwebsite/src/App.tsx:2839, and the only popout routes are chat, artifact and terminal (website/src/App.tsx:1736). The story no longer promises a chrome-less page.sidebar-folders-history-and-archive: the fixture sessionresearch-notesis titled "Research: MCP transport trade-offs" (src/kiro_crew/tests_fixtures/rich/sessions/dashboard_research-notes.jsonl:1) and the bottom pane is labelled Older Sessions (older_sessions_2atwebsite/src/pages/ChatSidebar.tsx:6968), not History. The shipped scenariosidebar-folders-and-older-sessionsalready uses both.sidebar-workspace-switcher-three-workspaces:git grep -n -i -E 'WorkspaceSwitcher|switch_workspace|switchWorkspace|workspace switcher' origin/main -- website/src src/kiro_crew ':!website/src/i18n/locales'finds nothing. Named workspaces are edited in Developer > Config and picked per crewmate, so the record becomesexcluded/P3 with that reason.FEATURES.mdis regenerated withpython test/gui_user/features_catalog.py --write. The counts block moves nightly 167 → 166 and excluded 22 → 23, and the informationalprioritiesandper_featureblocks follow.Backwards compatibility
Compatible: every record keeps its id and the validator and renderer are unchanged. One record changes tier, so it leaves the runnable tables.
Reader: test/gui_user/features_catalog.py:render -- release --
FEATURES.mdis regenerated in this commit andtest_features_md_is_rendered_from_features_jsonholds the pair togetherReader: test/gui_user/test_features_catalog.py:test_every_p0_is_runnable_on_the_target -- release -- the record is P3, which that test requires of every
excludedrecordgit grep -Ffor each of the nine ids onorigin/mainfinds onlyfeatures.jsonandFEATURES.md, exceptdeveloper-mcp-pool, whichwebsite/scripts/lib/i18n-surfaces.mjsalso uses as an unrelated surface key.Tests
In short:
test/gui_user/test_features_catalog.pypasses 3 of 3 on the head (35 tests), fails whenFEATURES.mdis not regenerated from the edited JSON, and all oftest/gui_user(305 tests), the 16 ratchet files (234 tests), docs-lint, the feature-map gate and the brand gate are green.test_features_catalog.pyalready holds the schema, registry slugs, record order,counts, "every excluded record is P3", shipped seeds, no cross-slug duplicate (the newcomponentvalues onchat-rewindanddeveloper-mcp-poolpass it) andFEATURES.md == render(load()).FEATURES.mdgives 1 failed, 34 passed (test_features_md_is_rendered_from_features_json); the regenerated file gives 35 passed.Manual verification
N/A for a UI run: no source or UI file changes. Every claim above was read back from
origin/mainwithgit greporgit show. For two records the shipped scenarios (auth-sign-in-card-signed-out,sidebar-folders-and-older-sessions) were already written against the corrected paths.Related Issues
Refs #19582
Adjacent open work: #19648 adds a catalog record and edits the same
countsblock offeatures.jsonandFEATURES.md; #19537 edits scenarios. Neither record is touched here. Whichever merges second regeneratesFEATURES.md.Pattern harvest
Rule candidate: lint
Pattern: a catalog record whose
sourceorcomponentpath no longer exists in the tree. Before this change 3 of the 270 records cited a missing file; this PR fixes two of them (the sign-in card moved) andcapabilities-crews-templates-skills-tabs(website/src/pages/AgentsPage.tsx) is the third. A check intest_features_catalog.pythat every such path exists would have caught the move.Checklist
FEATURES.mdregenerated, feature-map Rewind row corrected)