Repository navigation
fix(perf): pin utf-8 on the py-spy subprocess call - #20146
Conversation
`kirocrew perf sample` runs py-spy in text mode with no encoding, so the child's stdout and stderr are decoded with the host code page: mojibake on Windows, and a UnicodeDecodeError under a code page that cannot decode the bytes, which the function's `except OSError` clauses do not catch. Splat the shared UTF8_TEXT mapping instead. It carries text=True, so the explicit text=True goes. Drop the file's line from the subprocess-encoding baseline so the ratchet shrinks (#5249).
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683). |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: profiling with
[FIRST-PRINCIPLES-REVIEWED] b7cf071 Description read[DESCRIPTION-READ] cdf5b6cea1ab4ac93c8d827ee14002a9b98ed8c52c05630c4c566135975b7f31 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] b7cf071 Description read[DESCRIPTION-READ] 349408c13c6510d8c225cd2e70aebbe7d1f6f5d0123a77a7c2b11851a7de1f74 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: passes the shared UTF8_TEXT kwargs to the py-spy subprocess call instead of text=True and drops the file from the subprocess-encoding baseline.
Problem / Motivation
Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.
The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires:
1 src/kiro_crew/cli_perf.py.Why it matters
Without an explicit encoding,
subprocess.run(..., text=True)decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raisesUnicodeDecodeError(#5249). The repo lists every such call per file in.github/subprocess-encoding-baseline.txtand the gate lets each count only shrink.Not a goal
What changed (motivation → approach → change)
Each call below now pins UTF-8 (
encoding="utf-8", or the shared**UTF8_TEXTmapping fromkiro_crew.subprocess_utf8where the file's neighbours use it), and the file's baseline line is removed.src/kiro_crew/cli_perf.py:argv, capture_output=True, text=True, timeout=args.seconds + 60.github/subprocess-encoding-baseline.txt: removed1 src/kiro_crew/cli_perf.py.Backwards compatibility
Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.
Tests
RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.pyexits non-zero ("new offender(s)"), proving the gate still counts the old call.python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.pyexit 0, and the touched file' own tests pass with an unchanged count.Manual verification
N/A — unit coverage sufficient: the gate and the file's own tests exercise the changed lines directly.
Pattern harvest
Rule candidate: none new; the rule is already enforced by
scripts/check_subprocess_encoding.py(a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.Screenshots / video
Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.
No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #19928, #20014, #19527).