Repository navigation
fix(dashboard): pin utf-8 on the port_reclaim subprocess call - #20142
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] ad0c40a Description read[DESCRIPTION-READ] 40fd32e8f1daf60fd243ce167d89566d9d49dfef3a57d6c7f9b3de8165390db4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: make one text-mode subprocess call in the dashboard's port-reclaim path decode its output as UTF-8 on every platform. This is a FIX, a burn-down step for the documented
[FIRST-PRINCIPLES-REVIEWED] ad0c40a Description read[DESCRIPTION-READ] 539070db85450af6da6d0af8c5959e2a72dfe1e98eb5eb92a714a7226240350a That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683). |
The POSIX branch of _listeners_on_port runs lsof in text mode with no encoding, so subprocess decodes its output with the locale code page (#5249). Replace text=True with the shared UTF8_TEXT mapping, the form other dashboard modules already use, and drop the file's entry from the subprocess-encoding baseline so the list shrinks by one. lsof prints digits only, so decoding is unchanged on POSIX locales.
a555783 to
ad0c40a
Compare
|
Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683). |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: pins utf-8 decoding on the port_reclaim lsof subprocess call and drops that file from the subprocess-encoding baseline.
Problem / Motivation
Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.
The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires:
1 src/kiro_crew/dashboard/port_reclaim.py.Why it matters
Without an explicit encoding,
subprocess.run(..., text=True)decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raisesUnicodeDecodeError(#5249). The repo lists every such call per file in.github/subprocess-encoding-baseline.txtand the gate lets each count only shrink.Not a goal
What changed (motivation → approach → change)
Each call below now pins UTF-8 (
encoding="utf-8", or the shared**UTF8_TEXTmapping fromkiro_crew.subprocess_utf8where the file's neighbours use it), and the file's baseline line is removed.src/kiro_crew/dashboard/port_reclaim.py:text=True,.github/subprocess-encoding-baseline.txt: removed1 src/kiro_crew/dashboard/port_reclaim.py.Backwards compatibility
Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.
Tests
RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.pyexits non-zero ("new offender(s)"), proving the gate still counts the old call.python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.pyexit 0, and the touched file' own tests pass with an unchanged count.Manual verification
N/A — unit coverage sufficient: the gate and the file's own tests exercise the changed lines directly.
Pattern harvest
Rule candidate: none new; the rule is already enforced by
scripts/check_subprocess_encoding.py(a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.Screenshots / video
Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.
No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #19928, #20014, #19527).