Skip to content

fix(dashboard): pin utf-8 on the port_reclaim subprocess call - #20142

Merged
javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-port-reclaim
Oct 14, 2026
Merged

javenciu merged 1 commit into
mainfrom
fix/subprocess-encoding-port-reclaim

Conversation

@javenciu

@javenciu javenciu commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A text-mode subprocess call in 1 file decodes its child's output as UTF-8 on every platform instead of the locale's code page.

The subprocess-encoding gate counts, per file, the sites the repo still tolerates. This PR retires: 1 src/kiro_crew/dashboard/port_reclaim.py.

Why it matters

Without an explicit encoding, subprocess.run(..., text=True) decodes with the locale code page, which on Windows is not UTF-8: non-ASCII output becomes mojibake or raises UnicodeDecodeError (#5249). The repo lists every such call per file in .github/subprocess-encoding-baseline.txt and the gate lets each count only shrink.

Not a goal

  • Calls in files not listed here (each is its own one-mechanism PR).
  • Changing what any child process does or how its output is used.
  • Any refactor or reformatting of untouched lines.

What changed (motivation → approach → change)

Each call below now pins UTF-8 (encoding="utf-8", or the shared **UTF8_TEXT mapping from kiro_crew.subprocess_utf8 where the file's neighbours use it), and the file's baseline line is removed.

  • src/kiro_crew/dashboard/port_reclaim.py: text=True,
  • .github/subprocess-encoding-baseline.txt: removed 1 src/kiro_crew/dashboard/port_reclaim.py.

Backwards compatibility

Compatible: the call's return type and the output's meaning are unchanged; only the decode encoding is pinned.
Removes nothing: a baseline entry is a tolerance the gate stops needing, not a capability.

Tests

  • Deleting the baseline line with the file untouched: RATCHET_SCOPE_WHOLE_TREE=1 python3 scripts/check_subprocess_encoding.py exits non-zero ("new offender(s)"), proving the gate still counts the old call.
  • With the edit: python3 scripts/check_subprocess_encoding.py --test && python3 scripts/check_subprocess_encoding.py exit 0, and the touched file' own tests pass with an unchanged count.
  • flake8 clean on the touched file; the repo's baselined black gate passes.

Manual verification

N/A — unit coverage sufficient: the gate and the file's own tests exercise the changed lines directly.

Pattern harvest

Rule candidate: none new; the rule is already enforced by scripts/check_subprocess_encoding.py (a baselined CI gate that flags every text-mode subprocess call without an explicit encoding), and this PR retires baseline entries under it.

Screenshots / video

Why no screenshot: nothing renders; this change pins a subprocess decode encoding and a CI baseline only.

No issue exists; burn-down of the subprocess-encoding gate baseline (precedents #19928, #20014, #19527).

@javenciu
javenciu requested review from a team and KiroCrewCaptain as code owners October 14, 2026 05:33
@javenciu
javenciu requested a review from mbriones98 October 14, 2026 05:33
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ad0c40a853230958332e0981416f5cfc43ccbdb6 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ad0c40a853230958332e0981416f5cfc43ccbdb6 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] ad0c40a

Description read

[DESCRIPTION-READ] 40fd32e8f1daf60fd243ce167d89566d9d49dfef3a57d6c7f9b3de8165390db4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ad0c40a853230958332e0981416f5cfc43ccbdb6 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: make one text-mode subprocess call in the dashboard's port-reclaim path decode its output as UTF-8 on every platform. This is a FIX, a burn-down step for the documented check_subprocess_encoding.py gate.

  1. The lsof listener probe in port_reclaim.py now decodes as UTF-8 with errors="replace", using the existing UTF8_TEXT from src/kiro_crew/subprocess_utf8.py — justified
  2. The baseline entry for port_reclaim.py is removed, so the gate now fails if this file gains an unpinned call again — justified

[FIRST-PRINCIPLES-REVIEWED] ad0c40a

Description read

[DESCRIPTION-READ] 539070db85450af6da6d0af8c5959e2a72dfe1e98eb5eb92a714a7226240350a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ad0c40a853230958332e0981416f5cfc43ccbdb6 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ad0c40a

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ad0c40a853230958332e0981416f5cfc43ccbdb6: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ad0c40a853230958332e0981416f5cfc43ccbdb6 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ad0c40a

Verdict parsed from the review's SHA-scoped output markers for commit ad0c40a853230958332e0981416f5cfc43ccbdb6.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ad0c40a853230958332e0981416f5cfc43ccbdb6: <one-sentence reason>

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 14, 2026
@javenciu javenciu reopened this Oct 14, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 14, 2026
The POSIX branch of _listeners_on_port runs lsof in text mode with no
encoding, so subprocess decodes its output with the locale code page
(#5249). Replace text=True with the shared UTF8_TEXT mapping, the form
other dashboard modules already use, and drop the file's entry from the
subprocess-encoding baseline so the list shrinks by one.

lsof prints digits only, so decoding is unchanged on POSIX locales.
@javenciu
javenciu force-pushed the fix/subprocess-encoding-port-reclaim branch from a555783 to ad0c40a Compare October 14, 2026 11:09
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 14, 2026
@javenciu

Copy link
Copy Markdown
Contributor Author

Closing and reopening so CI runs on hosted runners: same-repo runs from this account queue on the fleet label without a runner (details on #19683).

@javenciu javenciu closed this Oct 14, 2026
@javenciu javenciu reopened this Oct 14, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 14, 2026
@javenciu
javenciu enabled auto-merge (squash) October 14, 2026 13:17

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: pins utf-8 decoding on the port_reclaim lsof subprocess call and drops that file from the subprocess-encoding baseline.

@javenciu
javenciu merged commit e569d3a into main Oct 14, 2026
113 of 175 checks passed
This was referenced Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants