Repository navigation
test(crew-log): drop the strict xfail on the warm-session savepoint guard - #24774
Conversation
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the xfail named its own fix, that fix has landed, and the test now runs as a plain guard. [DESIGN-REVIEWED] ac55c22 Description read[DESCRIPTION-READ] d13842ca20e71a7be4216302288bbceea9b115ace3f8480dd1639b939a3315d2 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
buluoray
left a comment
There was a problem hiding this comment.
Approving 112f3cd. This fixes the other red on main: #24276 made test_a_warm_session_read_that_earns_a_savepoint_reads_only_the_gap pass, so its strict xfail now fails as XPASS(strict) on Backend Tests (3.12, 2) and Windows (2) (main @ 82dbd99). The diff only removes that marker; every assertion stays.
The Backend Lint red here is not this diff: it is main's F821 in src/kiro_crew/publish_governance.py:299 (lists_checked_by_caller), fixed by #24767.
…uard kirodotdev#24276 made a warm session read that earns a savepoint write fold only the gap, so the guard now passes and strict mode fails it as XPASS on every PR. Enforce it as a plain test. Closes kirodotdev#24765 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
112f3cd to
ac55c22
Compare
Picks up kirodotdev#24774, which drops the stale xfail that fails strict on this PR's backend shard 2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem / Motivation
Goal: Backend Tests (3.12, 2) passes again on main and on every PR, with the warm-session savepoint guard enforced as a plain test.
test/test_crew_log_fullscan_guard.py::test_a_warm_session_read_that_earns_a_savepoint_reads_only_the_gapcarriesxfail(strict=True). #24276 (merged 05:33Z today) fixed the path it guards, so the test passes and strict mode fails it asXPASS(strict). Two unrelated PRs (#24743, #24742) show the same single failure on that shard:1 failed, 31322 passed.Why it matters
Every PR based on current main is red on shard 2 for a reason none of them caused, and the fixed path has no live guard against regressing.
Not a goal
What changed (motivation → approach → change)
Symptom: strict XPASS on shard 2. Cause: #24276 fixed
projection_session_memo._fold_session_warm_lockedand the marker stayed. Change: remove that one@pytest.mark.xfail(...)decorator. The whole file now reports 10 passed, 4 xfailed and no XPASS, so no other marker is stale.Backwards compatibility
Compatible: test-only change; no runtime code is touched.
Removes nothing: only a test decorator goes, which turns an expected failure into an enforced pass.
Tests
Proof: not provable -- test-only change
Controls, run locally on Windows / Python 3.13:
origin/main2dfb890, marker presentFAILED ... [XPASS(strict)](reproduces CI)src/kiro_crew/crew_log/reverted to before #24276AssertionError: ScanMeter(entries=701, ...): the plain test still catches the regressionDeterminism: the file passed three repeated runs, a reversed test order and
-n 4(10 passed, 4 xfailed each time).test_flake_pattern_ratchet.py: 62 passed.Manual verification
N/A — unit coverage sufficient: the change is one test decorator, and the controls above run the test against both the fixed and the unfixed source.
Related Issues
Closes #24765
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
🤖 Generated with Claude Code