Skip to content

test(crew-log): drop the strict xfail on the warm-session savepoint guard - #24774

Merged
buluoray merged 1 commit into
kirodotdev:mainfrom
leonlaiyc:claude/drop-session-savepoint-xfail
Oct 27, 2026
Merged

buluoray merged 1 commit into
kirodotdev:mainfrom
leonlaiyc:claude/drop-session-savepoint-xfail

Conversation

@leonlaiyc

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Backend Tests (3.12, 2) passes again on main and on every PR, with the warm-session savepoint guard enforced as a plain test.

test/test_crew_log_fullscan_guard.py::test_a_warm_session_read_that_earns_a_savepoint_reads_only_the_gap carries xfail(strict=True). #24276 (merged 05:33Z today) fixed the path it guards, so the test passes and strict mode fails it as XPASS(strict). Two unrelated PRs (#24743, #24742) show the same single failure on that shard: 1 failed, 31322 passed.

Why it matters

Every PR based on current main is red on shard 2 for a reason none of them caused, and the fixed path has no live guard against regressing.

Not a goal

  • Changing any test body or any production code.
  • Touching the other strict markers in the file; they still XFAIL on main.

What changed (motivation → approach → change)

Symptom: strict XPASS on shard 2. Cause: #24276 fixed projection_session_memo._fold_session_warm_locked and the marker stayed. Change: remove that one @pytest.mark.xfail(...) decorator. The whole file now reports 10 passed, 4 xfailed and no XPASS, so no other marker is stale.

Backwards compatibility

Compatible: test-only change; no runtime code is touched.

Removes nothing: only a test decorator goes, which turns an expected failure into an enforced pass.

Tests

Proof: not provable -- test-only change

Controls, run locally on Windows / Python 3.13:

Tree Result
origin/main 2dfb890, marker present FAILED ... [XPASS(strict)] (reproduces CI)
this branch 10 passed, 4 xfailed
this branch, src/kiro_crew/crew_log/ reverted to before #24276 AssertionError: ScanMeter(entries=701, ...): the plain test still catches the regression

Determinism: the file passed three repeated runs, a reversed test order and -n 4 (10 passed, 4 xfailed each time). test_flake_pattern_ratchet.py: 62 passed.

Manual verification

N/A — unit coverage sufficient: the change is one test decorator, and the controls above run the test against both the fixed and the unfixed source.

Related Issues

Closes #24765

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

🤖 Generated with Claude Code

@leonlaiyc
leonlaiyc requested review from a team and KiroCrewCaptain as code owners October 27, 2026 06:46
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision ac55c22fa79153b407c2f11cb8c260a9aa80860b ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision ac55c22fa79153b407c2f11cb8c260a9aa80860b touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of ac55c22fa79153b407c2f11cb8c260a9aa80860b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the xfail named its own fix, that fix has landed, and the test now runs as a plain guard.

[DESIGN-REVIEWED] ac55c22

Description read

[DESCRIPTION-READ] d13842ca20e71a7be4216302288bbceea9b115ace3f8480dd1639b939a3315d2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed ac55c22fa79153b407c2f11cb8c260a9aa80860b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ac55c22

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed ac55c22fa79153b407c2f11cb8c260a9aa80860b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ac55c22

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 27, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving 112f3cd. This fixes the other red on main: #24276 made test_a_warm_session_read_that_earns_a_savepoint_reads_only_the_gap pass, so its strict xfail now fails as XPASS(strict) on Backend Tests (3.12, 2) and Windows (2) (main @ 82dbd99). The diff only removes that marker; every assertion stays.

The Backend Lint red here is not this diff: it is main's F821 in src/kiro_crew/publish_governance.py:299 (lists_checked_by_caller), fixed by #24767.

@buluoray
buluoray enabled auto-merge (squash) October 27, 2026 07:03
…uard

kirodotdev#24276 made a warm session read that earns a savepoint write fold only
the gap, so the guard now passes and strict mode fails it as XPASS on
every PR. Enforce it as a plain test.

Closes kirodotdev#24765

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leonlaiyc
leonlaiyc force-pushed the claude/drop-session-savepoint-xfail branch from 112f3cd to ac55c22 Compare October 27, 2026 07:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 27, 2026
@buluoray
buluoray merged commit d069596 into kirodotdev:main Oct 27, 2026
227 of 237 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 27, 2026
leonlaiyc added a commit to leonlaiyc/KiroCrew that referenced this pull request Oct 27, 2026
Picks up kirodotdev#24774, which drops the stale xfail that fails strict on this PR's backend shard 2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Main red: strict xfail on the warm-session savepoint guard now passes after #24276

3 participants